QR code scan to open frontend mentor using html & css with grid

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @usamariaz2 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • Use min-height: 100vh to body selector, with this property you set a height and let the element grow even more if necessary. Your elements will also be vertically centered when you use this property, also, remove margin-top: 4rem;.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  2

  ---

  

  Usama Riaz•10

  @usamariaz2Posted about 2 years ago

  @MelvinAguilar Hi thanks Melvin its really very helpful guide;

  1
• 

  P

  Alexandru Stefan Gherhes•580

  @AlexandruStefanGherhesPosted about 2 years ago

  Hello @usamariaz2, good job on completing this challenge. I would recommend taking on the challenge to also have the element responsive on mobile display as well. On the body element, try adding the property "height:100vh" to have your container centered exactly in the middle of the screen.

  Outside of that you really did a great job.

  Marked as helpful

  0

  ---

  

  Usama Riaz•10

  @usamariaz2Posted about 2 years ago

  @AlexandruStefanGherhes thanks for guide Alexandru its awesome

  0