qr code

Community feedback

• 

  Vishal•260

  @vb8146649Posted 3 months ago

  !!!This isn't properly structured.!!!

  • use landmark tag such as main , footer , header . i.e the card should be inside a main .
  • dont use br unnecessarily , like you did in both heading and p . Make it flow naturally .
  • use h2 or lower heading since when integrating this component this wont be the main heading of a page , hence it should be h2 or lower.
  • use text-align:center in heading also .
  • I see the problem , you used width:fit-content in styling the body of the component thats why you have used br tag to mitigate the disaster . Its a bad practice dont use it like this. instead use a max-width styling that should be in rem or em , using px or vh or vw is never generally recommended .
  • No need to use flex since the tags are block and all will be displayed one after another. Using flex unnecessarily can only lead to disaster .
  • Accessibility : the image tag should have a well defined description , not like alt="image" when the image is important like a qr.

  0
• 

  Alexsander Gois•20

  @alxgoisPosted 4 months ago

  ok

  0