Design comparison
SolutionDesign
Solution retrospective
I pratice sass/scss in this project...trying to move to sass/scss :D
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Marco, It looks good!... You have
accessibility issues
that need to fix.Document should have one main landmark
, Contain the component with<main>
.Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page.
Hope this is useful to you... Keep coding👍
0@marcoberdianoPosted over 2 years ago@Bayoumi-dev Hi thanks for the feeback i will fix the accessibility issues with your suggestion, i was wondering how to fix it ;)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord