QR Code Responsiveness

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Tyler, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Tyler•40

  @Tyler430Posted almost 2 years ago

  @denielden Would mind explaining the Accessibility? And would you use px for positioning and rem for sizing?

  Thanks!

  • Tyler

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @Tyler430 You are welcome and keep it up :)

  For a full explanation of accessibility read here

  I use rem everywhere

  0
• 

  Mishael•320

  @mishael-codesPosted almost 2 years ago

  Hello Tyler

  You have done well in your code

  However, to address the complaint you made, rather that use the position property, try this...

  body{
      display: flex;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  The above code snippet makes the minimum body-height exactly the height of the screen viewport min-height:100vh. Therefore, centering the container in the middle of the page.

  For more explanation on the vh unit, check

  • w3schools

  Marked as helpful

  1