QR Code Responsive Design

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 3 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • It is best practice to use margin-inline: auto; to center left and right then than just margin: auto;, You can center the height by using this code snippet

    min-height: 100svh;
    display: flex;
    justify-content: center;
    flex-direction: column;
  

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  1

  ---

  

  RoshownH•10

  @RH-NixPosted 3 months ago

  @Stroudy Thank you. Updated

  1
• 

  fortunat81•90

  @fortunat81Posted 3 months ago

  good job ! Dimensions are a bit off.

  1

  ---

  

  RoshownH•10

  @RH-NixPosted 3 months ago

  @fortunat81 Thanks! Still updating to get them right.

  0