QR code responsive component using HTML and CSS Flex

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 8 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with QR code image is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  P

  Aminpatra•260

  @AminpatraPosted 8 months ago

  You can make the body it self flex to center the card, by giving it height of 100vh or better height : calc(100vh - 1px) -> to not make the shaky feeling in mobile. Instead of defining a container and give it the height of the page so the final result we be like this : body {display: flex; flex-direction: column; justify-content: center; align-items: center; height : calc (100vh - 1px)} or you can just use (display: grid; place-content: center;) instead of flex properties. Hope this helped you.

  Marked as helpful

  1
• 

  P

  Anton Vasilache•580

  @AntonvasilachePosted 8 months ago

  Hey @Aminpatra,

  Thanks for the feedback.

  I have adjusted the size to 100vh, now it looks more aligned with the design file. I have added a container just to try and avoid using too many properties on the html body, but I think your solution would work great as well, grid part included.

  Cheers!

  1