Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code replica utilizing CSS & HTML

@Dr4gonH34RT

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback is greatly appreciated because I am very new to front-end development.

Community feedback

@bccpadge

Posted

Hello @Dr4gonH34RT and Congrats on completing this challenge 🎉!

I have a couple tips to improve your solution.

HTML

  • You are not use a landmark on your website and to fix that you can use a <main> tag instead of a <div>

HEADING TAGS

  • Make sure you are using heading tags in chronological order
  • Change your h2 to an h1
  • HTML Heading Tags

Here is my solution to this challenge and if you need more help do not hesitate to reach out to me.

Hope this helps you!

Marked as helpful

0

@Dr4gonH34RT

Posted

Thank you for your feedback I thought the body and main tags function the same way therefore did not use it on the other hand now I know the importance of heading order. @bccpadge

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility
  • Example: <h1>Improve your front-end skills by building projects</h1>
  • If you have any questions or need further clarification, and feel free to reach out to me.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord