QR code

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 8 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap .content in a <main>.

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

  • .footer should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Remember to specify a fallback font, in case the user can't access the declared font:font-family: 'Outfit', sans-serif;.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove all positioning properties.

  • On the body, remove the width - block elements take up the full width by default. Change height to min-height - this way, the content will not get cut off if it grows beneath the viewport. Add flex-direction: column and gap: 2rem, to create space between the main and the footer.

  • Remove the width on the card.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Do not use % for padding. The card should have equal padding on all sides, so you can use the shorthand:padding: 1rem - this sets the padding on all 4 sides to 1rem.

  • On the image, remove width, height and max-height. Add display: block and change max-width to 100% - the max-width prevents it from overflowing its container.

  0