Design comparison
Solution retrospective
Not really proud of anything. I would do a lot differently. x)
What challenges did you encounter, and how did you overcome them?Well, the only challenge possible here, not knowing how to properly use CSS for centering the content, making a footer and all. I had some help.
What specific areas of your project would you like help with?Had a really hard time with the usage of positon absolute/relative, using the display flex and trying to figure out the size of marging and padding without the figma (tried to do it only with the 2 designs)
Community feedback
- @Islandstone89Posted 8 months ago
HTML:
-
Every webpage needs a
<main>
that wraps all of the content, except for<header>
andfooter>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap.content
in a<main>
. -
The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).
-
.footer
should be a<footer>
, and you should use<p>
for the text inside.
CSS:
-
Including a CSS Reset at the top is good practice.
-
Remember to specify a fallback font, in case the user can't access the declared font:
font-family: 'Outfit', sans-serif;
. -
Add around
1rem
ofpadding
on thebody
, so the card doesn't touch the edges on small screens. -
Remove all positioning properties.
-
On the
body
, remove the width - block elements take up the full width by default. Changeheight
tomin-height
- this way, the content will not get cut off if it grows beneath the viewport. Addflex-direction: column
andgap: 2rem
, to create space between the main and the footer. -
Remove the width on the card.
-
Add a
max-width
of around20rem
on the card, to prevent it from getting too wide on larger screens. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Since all of the text should be centered, you only need to set
text-align: center
on the body, and remove it elsewhere. The children will inherit the value. -
Paragraphs have a default value of
font-weight: 400
, so there is no need to declare it. -
Do not use
%
forpadding
. The card should have equal padding on all sides, so you can use the shorthand:padding: 1rem
- this sets the padding on all 4 sides to1rem
. -
On the image, remove
width
,height
andmax-height
. Adddisplay: block
and changemax-width
to100%
- the max-width prevents it from overflowing its container.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord