QR code project with plain html/css
Design comparison
Solution retrospective
Let me know what I can do to improve my project! Thank you!
Community feedback
- @denieldenPosted about 2 years ago
Hi Jerome, congratulations on completing the challenge, great job! π
Some little tips for optimizing your code:
- you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
from.container
class because with flex they are superfluous - add
width: 20rem
to.container
class - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding π
0 - you can use
- @correlucasPosted about 2 years ago
πΎHi Jerome, congratulations for your first solution!π Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw youβre on the right track. Iβve few suggestions to you that you can consider to add to your code:
1.Replace the
<h2>
heading with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.2.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.βοΈ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord