QR code project with plain html/css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Jerome, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .container class because with flex they are superfluous
  • add width: 20rem to .container class
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Jerome, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Replace the <h2> heading with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  0