Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code project with plain html/css

Jerome Dela Cruzβ€’ 210

@noonecaresman023

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Let me know what I can do to improve my project! Thank you!

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hi Jerome, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .container class because with flex they are superfluous
  • add width: 20rem to .container class
  • instead of using px use relative units of measurement like rem -> read here

Hope this help! Happy coding πŸ˜‰

0
Lucas πŸ‘Ύβ€’ 104,420

@correlucas

Posted

πŸ‘ΎHi Jerome, congratulations for your first solution!πŸ‘‹ Welcome to the Frontend Mentor Coding Community!

Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

1.Replace the <h2> heading with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

✌️ I hope this helps you and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord