Design comparison
Solution retrospective
I am most proud of the fact I learned alot about github and how to properly commit changes and deploy a site. I am also porud of the fact that I learned how to make a design for different screen sizes. The thing I would do differently next time is I would begin by designing for the smallest screen size first.
What challenges did you encounter, and how did you overcome them?One challenge I encountered was I created an original design and then realised it did'nt work for the smaller screen sizes. I had to completely restart the css and make new sizing for each of my elements. Another challenge I faced was learning how to use github and deploying my site. I struggled with the deployment and committing changes.
What specific areas of your project would you like help with?I would like feedback on how i should structure it differently and if I should use media queries for the different screen sizes.
Community feedback
- @StroudyPosted about 2 months ago
Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…
-
For this challenge you dont need to worry about
@media
, -
You have used a lot of
<div>
, Using a<div>
instead of a more semantic element is a bad idea because it lacks meaning and context, reducing accessibility, SEO effectiveness, and clarity for screen readers and developers. -
Avoid using
id
selectors for styling in CSS because they are too specific and hard to override, making your styles less flexible and maintainable. Instead, use class selectors (.
), which are reusable and more manageable, allowing for better control over your styles and easier updates. -
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
Missing a
alt=" "
on your<img>
, Having a clear and descriptivealt
text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines usealt
text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images,
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord