Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
Metadata 🗃️:
- The
langattribute is used to declare the language of the webpage. Add thelangattribute to the<html>tag with the valueen.
HTML 🏷️:
-
Wrap the page's whole main content in the
<main>tag. -
Since this component involves scanning the QR code, the image is not a decoration, so it must have an
altattribute. Thealtattribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS 🎨:
- Setting the max-width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of
320pxor20remto make sure that the component will have a maximum width of320pxon any device, also remove themax-width: 35%;property.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
1
Mobile_Koda• 140
@Lemon-stack
Posted
@MelvinAguilar Thanks for your amazing feedback, I never had any idea that this where some ethics. I'm indeed grateful, I'll copy your feedback into my note so I'll be able to follow your guide practically 🙂
0
