Design comparison
Solution retrospective
What do you like about this project?
Community feedback
- @MelvinAguilarPosted 12 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
Metadata ๐๏ธ:
- The
lang
attribute is used to declare the language of the webpage. Add thelang
attribute to the<html>
tag with the valueen
.
HTML ๐ท๏ธ:
-
Wrap the page's whole main content in the
<main>
tag. -
Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS ๐จ:
- Setting the max-width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of
320px
or20rem
to make sure that the component will have a maximum width of320px
on any device, also remove themax-width: 35%;
property.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@Lemon-stackPosted 12 months ago@MelvinAguilar Thanks for your amazing feedback, I never had any idea that this where some ethics. I'm indeed grateful, I'll copy your feedback into my note so I'll be able to follow your guide practically ๐
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord