Skip to content
Submitted about 1 year ago

QR code project using HTML and CSS

Mobile_Koda•140
@Lemon-stack
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What do you like about this project?

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 1 year ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    Metadata 🗃️:

    • The lang attribute is used to declare the language of the webpage. Add the lang attribute to the <html> tag with the value en.

    HTML 🏷️:

    • Wrap the page's whole main content in the <main> tag.

    • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

    CSS 🎨:

    • Setting the max-width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the max-width: 35%; property.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful
    1
    Mobile_Koda•140
    @Lemon-stackPosted about 1 year ago

    @MelvinAguilar Thanks for your amazing feedback, I never had any idea that this where some ethics. I'm indeed grateful, I'll copy your feedback into my note so I'll be able to follow your guide practically 🙂

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord