Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR CODE PROJECT

@hgcfkuyfliyfl

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


feedbacks are welcomed

Community feedback

@Bishalsnghd07

Posted

Hi, @hgcfkuyfliyfl

Congrats for complete this challenge🎉

A few suggestions for you might be helpful.

  1. To make your HTML more semantic always follow heading level, instead of using h3 directly use h1 tag. Each page h1 tag should be mandatory to maintain semantic ui. And Heading level should be like this <h1> <h2> <h3> <h4> <h5> and <h6> and you should not be skipped any of this label. Always start with h1 and end with h2. h1 is the most important tag it is always use for main title and heading and h6 would be least important.

2.Second, you used br tag many time to separate the paragraph text and making it into different line, instead of that you can use much better approach by giving max-width so that your paragraph text will wrap in different line and work as same as br tag. It will improve your code quality.

Hope my suggestion will help you!

0

@hgcfkuyfliyfl

Posted

@Bishalsnghd07 "Thank you for the suggestions! I'll definitely keep them in mind to enhance the semantic structure and improve the code quality of my project."

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord