QR Code project (HTML and CSS)

Community feedback

• 

  Krushna Sinnarkar•1,100

  @krushnasinnarkarPosted 4 months ago

  Hi @CAF2801,

  Congratulations on successfully completing the challenge!

  Your solution looks great, but I have a few suggestions that might help improve it:

  1. QR Image Visibility: It seems the QR image isn't visible because the image file wasn’t uploaded to your repository. Please upload the image file and update the src attribute of the img tag accordingly.

  2. Dimensions: Avoid using fixed units like px for width and height. Instead, use relative units such as 100% for width and 100vh for height to make your design more responsive.

  3. Centering the Component: The current method of using margin to center .main-content isn’t ideal. For perfect centering, use Flexbox. You can achieve this by adding the following styles to #container:

     display: flex;
     align-items: center;
     justify-content: center;
     height: 100vh;
     

     This will center .main-content both vertically and horizontally.

     If you're not familiar with Flexbox, you can learn more here:

     • MDN Web Docs - Flexbox
     • W3Schools - Flexbox

  I hope you find these suggestions helpful.

  Feel free to reach out if you have more questions or need further assistance.

  Happy coding!

  Marked as helpful

  0

  ---

  

  CAF2801•30

  @CAF2801Posted 4 months ago

  Thank you so much for the feedback. I'll check the links you gave me for sure ! @krushnasinnarkar

  0
• 

  Bharath kumar•10

  @Saibharath108Posted 4 months ago

  good

  0