Skip to content
Submitted almost 2 years ago

QR Code project

Caleb M•20
@sparechange169
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This was my first actual project so I did find it quite difficult. I'm not sure how clean my code is but hoping for the best

Community feedback

  • Josh•400
    @burrijwPosted almost 2 years ago

    Hi Caleb! This is a really, really strong start! 💪🏻

    • Make sure you have landmarks, especially <main> .
    • You can get away with less markup. No need to wrap things in a div unless it’s for a particular purpose. All you need on this one is:
    <body>
  <main>
    <img />
    <h1>...</h1> 
    <p>...</p>
  </main>
</body>
    • Use padding for space inside of a component, and margin for space around it. You have margin around the image when all you really need is a consistent padding inside the card.
    • Font sizing might be a little off to my eye. Double check it if you care to. 🙂
    Marked as helpful
    0
    Caleb M•20
    @sparechange169Posted almost 2 years ago

    @burrijw Josh, thank you for the advice man!

    0
  • Hoshiko•180
    @oliwiakrammPosted almost 2 years ago

    This comment was deleted 10 months ago

    0
    Caleb M•20
    @sparechange169Posted almost 2 years ago

    @oliwiakramm Yeah I was definitely thrown for a loop with positioning elements. I appreciate the feedback

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord