Naveen Gumaste• 10,460
@NaveenGumaste
Posted
hay! T2001Kaye Nice work
Marked as helpful
1
Design comparison
Community feedback
Hexer• 3,660
@Phalcin
Posted
Good job overall man. Nice work
Marked as helpful
1
Travolgi 🍕• 31,420
@denielden
Posted
Hi 2001Kaye, great job! Congratulations on completing the challenge.
I had a look at your solution and I have a few suggestions for you:
- The
maintag not need attributerolebecause is semantic tag
Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid:
- try to use flexbox to the body for center the card. Read here -> flex guide
- also set
heigthof body to100vhbecause Flexbox aligns to the size of the parent container.
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord