QR code page with HTML and CSS

Community feedback

• 

  JimTK16•370

  @JimTK16Posted 12 months ago

  Nice first one Maria.

  A couple things to consider are:

  • Put your .card in the <main> tag so your code look more semantic.
  • Avoid setting fixed width for your container, instead of width:300px, you can set max-width: 300px.
  • Setting the height of the container in this case is not necessary i think, you can toggle this property in the devtool and see the changes it makes.
  • There no changes in layout between mobile and desktop version, and the content can fit in just 1 column, so I think flexbox might be an easier option than grid. Hope it helps!

  Jim

  Marked as helpful

  0

  ---

  

  maría•10

  @mariaigle98Posted 12 months ago

  Hi @JimTK16 thank you so much for your feedback! I'll take it all into account and improve my code.

  1
• 

  Thiago Correa•350

  @ThiagoBRG60Posted 12 months ago

  Hey, it looks great for a first challenge, just make sure to match the colors. Always keep learning and improving 😉.

  Marked as helpful

  0

  ---

  

  maría•10

  @mariaigle98Posted 12 months ago

  Hi @ThiagoBRG60 thank you for your feedback! I definitely need to pay more attention to colors 😅

  1