Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code page

Elyas 30

@ElyasKing

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any help for the responsive view ?

Community feedback

@MonjedNidal

Posted

You did a great job but, you should work in the layout of your code. like putting CSS code in separated file and I saw in your CSS you duplicated the font family style, if you see all the texts in the project has the same font family you can give the body this style and all the text elements will be effected.

Marked as helpful

2

Elyas 30

@ElyasKing

Posted

Thanks a lot for your feedback @MonjedNidal !

New fix :

  • CSS on separated file
  • Optimisation (ciao grid, hello flexbox)
  • Selected size (Desktop: 1440px)
  • Factorization of family style

You can check the repo all changes Now I have to work on the responsive view :)

0

@MonjedNidal

Posted

@ElyasKing I see. Nice work, keep going

0
Elyas 30

@ElyasKing

Posted

@MonjedNidal Your encouragement is appreciated, thank you very much for your support

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord