QR code page

Community feedback

• 

  Monjed Maswadeh•380

  @MonjedNidalPosted over 1 year ago

  You did a great job but, you should work in the layout of your code. like putting CSS code in separated file and I saw in your CSS you duplicated the font family style, if you see all the texts in the project has the same font family you can give the body this style and all the text elements will be effected.

  Marked as helpful

  2

  ---

  

  Elyas•30

  @ElyasKingPosted over 1 year ago

  Thanks a lot for your feedback @MonjedNidal !

  New fix :

  • CSS on separated file
  • Optimisation (ciao grid, hello flexbox)
  • Selected size (Desktop: 1440px)
  • Factorization of family style

  You can check the repo all changes Now I have to work on the responsive view :)

  0

  

  Monjed Maswadeh•380

  @MonjedNidalPosted over 1 year ago

  @ElyasKing I see. Nice work, keep going

  0

  

  Elyas•30

  @ElyasKingPosted over 1 year ago

  @MonjedNidal Your encouragement is appreciated, thank you very much for your support

  1