QR code page using Positioning and Flexbox

Community feedback

• 

  P

  beowulf1958•1,450

  @beowulf1958Posted 2 months ago

  Congratulations on completing this challenge. You did a really great job centering the card on the page, and positioning the text in the card. However, the image does not show on the page. This is because you did not include a picture in your folder. In order for an image to show up, it must be in the same folder as your html and css file. I have created a fork on your github with a copy of the image. I also had to remove the height on the container and img to get it to fit. Take a look and see what you think.

  Marked as helpful

  2

  ---

  

  zaydcodes•30

  @zaydcodesPosted 2 months ago

  hey thanks you so much for the info.@beowulf1958

  0
• 

  P

  Teodor Jenkler•3,760

  @TedJenklerPosted 2 months ago

  Hi @zaydcodes,

  Nice project! As mentioned before, the image isn’t working, but here are a few additional improvements you might consider:

  OG Meta Tags: Since your project is shareable by nature, adding OG (Open Graph) meta tags would be beneficial. They can significantly enhance SEO and make the shared links more attractive by including images and descriptions.

  Heading Structure: Instead of using two headings, consider using a single <h1> tag followed by a <p> tag. You can then style them with CSS to achieve the desired look. This approach will improve the semantic structure of your page and make it more accessible.

  Clickable QR Code: Additionally, consider making the QR code clickable so that users, especially older ones, can access the link directly without needing to scan the code. Alternatively, you can include the link below the QR code.

  Keep up the great work!

  Best, Teodor

  0