QR Code page using only HTML and CSS

Community feedback

• 

  Kuraanal•210

  @KuraanalPosted over 1 year ago

  You don't actually need all your divs.

  using flex you can have the following structure

  <div class="card">
  <img src="assets/images/image-qr-code.png" alt="QR Code to scan" class="card__picture">
  <h2 class="card__title">Improve your front-end skills by building projects</h1>
  <p class="card__text">Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  </div>
  

  and it will all be aligned with the following css

  .card {
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  }
  

  Hope this help you.

  Marked as helpful

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add Semantic HTML tags

  The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page

  Marked as helpful

  0