QR code page using Html & Css

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Abas Alamin, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Replace the <h2> heading with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  3.Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  4.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  0
• 

  ...•600

  @HatimHJPosted about 2 years ago

  .container-grid {
      display: grid;
      width: 200px;
  
      /*  grid-template-rows: 1fr 140px;  */
  
  }
  

  0