Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHi Abas Alamin, congratulations for your first solution!๐ Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw youโre on the right track. Iโve few suggestions to you that you can consider to add to your code:
1.Use
<main>
instead of<div>
to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.2.Replace the
<h2>
heading with<h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use ever the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.3.Add a margin of around
margin: 20px
to avoid the card touching the screen edges while it scales down.4.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.โ๏ธ I hope this helps you and happy coding!
0 - @HatimHJPosted about 2 years ago
.container-grid { display: grid; width: 200px; /* grid-template-rows: 1fr 140px; */ }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord