@MelvinAguilar
Posted
Hi @Takeda-harsh 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉
I have some suggestions you might consider to improve your code:
- Instead of using
<section>to wrap all the main content, use<main>tag .
- Instead of using pixels in font size, use relative units of measure like
remorem. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
- To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
- The space between the component and the content (text, image) is large, try to reduce it
. I hope those tips will help you! 👍
Good job, and happy coding! 😁
Marked as helpful
@Takeda-harsh
Posted
@MelvinAguilar Thanks for the feedback. I have a lot to learn. These tips are definitely helpful and I did leave out the accessibility options like the alt text for the QR code. I'll improve my codes in the new challenges I take.
@Takeda-harsh
Posted
@MelvinAguilar Thanks for the feedback. I have a lot to learn. These tips are definitely helpful and I did leave out the accessibility options like the alt text for the QR code. I'll improve my codes in the new challenges I take.
