QR CODE PAGE USING HTML AND CSS

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted about 2 months ago

  HTML:

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • Do not use <br> to force text onto a new line. The text should flow naturally, and all styling, including space between elements, should be done in the CSS.

  • Text should always be wrapped in a meaningful element, never in divs alone. Hence, the footer text needs to be wrapped in a <p>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport. Remove the width, as the body (and other block elements) take up the full width as the default. I would also add gap: 2rem, and remove position: fixed on the footer.

  • Remove all widths, max-widths and heights in px and %.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  Marked as helpful

  1

  ---

  

  Irfan•70

  @codebyMMPosted about 2 months ago

  thanks for the insight sir @Islandstone89 . Appreciate it so much..

  1
• 

  Natali Grimm•430

  @Grimm-NPosted about 2 months ago

  Thank you for your work on the code! It actually inspired me to add a footer to my project, even though it wasn't in the original assignment. The implementation looks great overall, though I noticed a slight mismatch in the spacing and font size compared to the design. However, I find the execution to be more visually pleasing than the design itself; the text looks more harmonious. Great job!

  P.S.: U forgot about the shadow ;-)

  Marked as helpful

  0
• 

  A. Montesino•30

  @amontesinoPosted about 2 months ago

  The font is slightly smaller than the design spec (this could very well be a resolution thing, the font size appears correct in the code!), and the container is missing a box-shadow, but otherwise all other dimensions of the container and elements within it match the spec. Great job using --root variables for colors as well!

  Marked as helpful

  0
• 

  hasnatlubaid•110

  @hasnatlubaidPosted about 2 months ago

  great

  0
• 

  P

  Quentin Lopes•50

  @QLopes22Posted about 2 months ago

  Your code looks very organized, great use of the comments.

  0