Qr code page

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Jonata-tr 👋, good job on completing this challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • Instead of using <section> to wrap the whole content, use <main> tag.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • Once you update the main container, use max-width: 18rem to main selector instead of width, this will make the container card a bit responsive on mobile and set the element's maximum width to 18rem.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  2

  ---

  

  Jonatan Trindade•120

  @Jonata-trPosted about 2 years ago

  @MelvinAguilar oooh, thanks for the feedback... this are some realy cool tips. I will definitely take a look and change my code.

  1