QR code page

Community feedback

• 

  Abdul Rasman•320

  @CodeWithDionPosted over 1 year ago

  Congratulations on completing the challenges!

  I have a suggestion regarding the font usage. It appears that the font family has not been imported, but you can do so by adding the following code at the top of your CSS file: '@import url('https://fonts.googleapis.com/css2family=Outfit:wght@400;700&display=swap');'. Additionally, you can specify 'font-family: 'Outfit', sans-serif;' in the body section of your CSS file to use the imported font family.

  Happy coding!"

  Marked as helpful

  1

  ---

  

  Seif017•90

  @Seif017Posted over 1 year ago

  Thanks i will make sure to add that@CodeWithDion

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Seif017•90

  @Seif017Posted over 1 year ago

  Thanks alot i really appreciate your advice @0xAbdulKhalid

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Great job on writing this code! You have demonstrated a good understanding of the concepts and applied them effectively to solve the problem. One suggestion I have is to add an alt attribute to the img tag because it provides a text alternative for the image, which is useful in several ways:

  Accessibility: Users with visual impairments rely on screen readers to access the content on web pages. The alt text helps the screen reader software to describe the content of the image, which makes the page more accessible.

  SEO: Search engine crawlers use the alt text to understand the content of the image, which can help the page to rank better in search engine results.

  Display issues: In some cases, the image may not be displayed due to slow internet connection or other technical issues. The alt text can help to provide context and information about the image, even if it's not visible.

  So, it's a good practice to always include an alt attribute with a descriptive text for each image in order to improve accessibility and optimize SEO. Here's an example:

  <img src="/images/code.png" alt="qr-code">
  

  Marked as helpful

  0

  ---

  

  Seif017•90

  @Seif017Posted over 1 year ago

  Thanks i am still new to html and css so i didn't know that@Kamlesh0007

  0