Design comparison
Solution retrospective
I am not sure if it can be done in a few lines or not, but for me, it took 55 lines of CSS and 23 lines of HTML.
Positioning the width and height of the card was somewhat challenging, but I anyway completed.
Please provide feedback if any š
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @ipv4aditya!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
1@ipv4adityaPosted 9 months agoThank you so much for your feedback, @danielmrz-dev I implemented your suggestion and it works totally fine.
Thanks a lot once again ā¤ļø
0 - Using
- @AmirezaMahmoudiPosted 9 months ago
nice job my recommendation(opinion) is to use h1 tag instead of p for the first sentence . what i usually do when i want to put contents in the middle of page i set a 100vh height for the body element then use flex to align it. i think you can make some changes that will make it more similar to the actual design like use the background color and text colors provided in the style guide.
0@ipv4adityaPosted 9 months agoThank you for your input, @AmirezaMahmoudi ! Will surely consider it. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord