QR Code Page

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 9 months ago

  Hello @ipv4aditya!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  1

  ---

  

  Aditya•20

  @ipv4adityaPosted 9 months ago

  Thank you so much for your feedback, @danielmrz-dev I implemented your suggestion and it works totally fine.

  Thanks a lot once again ❤️

  0
• 

  Amirreza•270

  @AmirezaMahmoudiPosted 9 months ago

  nice job my recommendation(opinion) is to use h1 tag instead of p for the first sentence . what i usually do when i want to put contents in the middle of page i set a 100vh height for the body element then use flex to align it. i think you can make some changes that will make it more similar to the actual design like use the background color and text colors provided in the style guide.

  0

  ---

  

  Aditya•20

  @ipv4adityaPosted 9 months ago

  Thank you for your input, @AmirezaMahmoudi ! Will surely consider it. :)

  0