QR code page

Community feedback

• 

  Boris•2,870

  @mkborisPosted 3 months ago

  Hi @Tcode2024, great job completing your first challenge here are a few things to review

  • Use a separate file for your CSS as it improves maintainability.
  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
  • The text content in these div elements should be semantically wrapped in more appropriate HTML tags like headings h2 or paragraphs p for better accessibility and structure.
  • Font-size should be written in rem not px

  Marked as helpful

  0

  ---

  

  Tcode2024•10

  @Tcode2024Posted 2 months ago

  @mkboris Thank you for your constructive feedback, I shall update my code to incorporate those key points.

  1
• 

  Bruno Henrique•70

  @brunohenriquedeveloperPosted 3 months ago

  Congratss, you did really well!

  Marked as helpful

  0

  ---

  

  Tcode2024•10

  @Tcode2024Posted 2 months ago

  @brunohenriquedeveloper thank you

  0