Frontend Mentor | QR code page coding challenge solution

Community feedback

Boris• 2,870

@mkboris

Posted 26 days ago

Hi @Tcode2024, great job completing your first challenge here are a few things to review

Use a separate file for your CSS as it improves maintainability.
All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
The text content in these div elements should be semantically wrapped in more appropriate HTML tags like headings h2 or paragraphs p for better accessibility and structure.
Font-size should be written in rem not px

Marked as helpful

@Tcode2024

Posted 25 days ago

@mkboris Thank you for your constructive feedback, I shall update my code to incorporate those key points.