Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .container on the page using flexbox, add min-height:100vh and justify-content: center to the body .
To center .container on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
There is no need to give .container a margin value.
For a responsive content which wont require a media query for this challenge, replace the width in .container with max-width and give it a fixed width value. eg:
max-width: 320px
.Give h1 and p the same font-size of 15px, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @KarenMascarenhasLourencoPosted almost 2 years ago
Thank you so much for your feedback, I really appreciated I'll apply the changes into the code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord