Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code

Abirami 20

@abira02

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my second submission. I changed the mistakes I made previously hope it's good now.

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi, Abirami! 👋

Alternative text should not be hyphenated like class names. It will be read by screen readers to humans. So, it should be in a readable format.

I recommend improving the alternative text by describing the destination or the purpose of the QR code.

I recommend adding width and height attributes to each image element. This way, browsers will know how much space the images require before they are loaded. As a result, it will prevent the layout shift.

You should use flexbox to position the card to the middle of the page instead of setting padding-top on the <body> element.

You don't need to specify width to the <h1> and <p>. You should control the line break by adjusting the padding of the card.

The card doesn't need width and height. It only needs max-width to prevent it from getting too large. For the height of it, let the content controls it.

I strongly recommend using a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset | Andy Bell

I hope you find this useful. Happy coding! 😄

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord