QR code

Community feedback

• 

  Boris•2,880

  @mkborisPosted 3 months ago

  Hi @shaywalker5 great job completing your first challenge, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around the .container
  • Use a separate file for your CSS as it improves maintainability.
  • The text content in these div elements (.attribution, .caption) should be semantically wrapped in more appropriate HTML tags like headings h2 or paragraphs p for better accessibility and structure.
  • Your image needs a more descriptive alt attribute like so alt="Qr Code to Frontendmentor.io"
  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability. Change the width of the .container to max-width and it should be defined in rem.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • You can use the PerfectPixel extension if you are trying to match the design

  Hope this helps, Good luck!

  Marked as helpful

  1