QR code made with HTML and CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="box-content">with the main tag, <h2> with <h1>and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To make the image visible, remove "/images" from the src value of the img. <img src="image-qr-code.png" alt="qr"> instead of <img src="/images/image-qr-code.png" alt="qr">

  To center .box-content on the page using flexbox, replace the height in the body with min-height: 100vh.

  Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Replace the height in .card with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 16px

  For a responsive content, replace the width in .box-content with max-width and give the img a max-width of 100% instead of a width, height and margin value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Dgrl•260

  @DouglasgrlPosted over 1 year ago

  Hola buenas , genial completando tu desafio solo unas cosas que creo que te ayudaran.

  Envuelve todo el texto en una etiqueta de main Utilice elementos semánticos HTML5 como <header>, <nav>, <main>, <aside>y <footer>para definir estas secciones.

  No te aparece la imagen porque en el index, colocaste img src="/images/image-qr-code.png", y la carpeta no existe puedes probar eliminando el /images o creando una carpeta llamada images y enviar la imagen a la carpeta , para que te pueda aparecer.

  Espero te sirva de ayuda.

  0
• 

  Niko•10

  @nikomowPosted over 1 year ago

  Hey, I looked at your github and your image was on the same level as the rest of the code the src should be

  <img src="image-qr-code.png" alt="qr">

  instead of

  <img src="/images/image-qr-code.png" alt="qr">

  :> i figured that when you imported it is when you made a mistake

  0