QR code landing page using CSS and HTML

Community feedback

• Account deleted

  Hey Mouhibeddine, congratulations on completing the challenge!

  You must named the html file like index.html to see it and upload the image to the repository.

  Let me give you some little tips for optimizing your code:

  • create style.css sheet and use it for the style instead of write the css inside html because best mode is separade the code
  • add main tag and wrap the card to improve the Accessibility
  • instead of div you can use article tag for the container of card and improve the Accessibility
  • use h1 for the title of card and not h3
  • remove all margin from div
  • use flexbox to the body to center the card. Read here -> flexbox guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement like rem -> read here it's much better!

  Hope this help! Happy coding 😁 by Travolgi

  Marked as helpful

  0