Skip to content
Submitted over 2 years ago

QR Code Landing page

Amina Ibrahim•10
@aminafolio
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I couldn't get the footer to go to center and I haven't learnt css grid yet. I will start learning it today. Other than the concepts I dont know, is the project okay, it terms of responsiveness and closeness to design?

Community feedback

  • Deepak Parmar•490
    @deepak-parmarPosted over 2 years ago

    @aminafolio,

    The attribution section isn't necessary to keep since it's not part of the designs and might interfere with the design. I usually don't keep attribution.

    However you need to take care of some accessibility issues. Screen reader devices requires landmark element to jump on when page loads therefore...

    • Wrap your .root element with landmark tag main
    • prefer to wrap .attribution using footer tag, if you're planning to keep it.

    Other than these, your work looks nice and code is decently structured. Nice work 👍

    Marked as helpful
    0
    Amina Ibrahim•10
    @aminafolioPosted over 2 years ago

    @deepak-parmar Thank you for the detailed remarks. I have added main now. I deleted attribute when i first started and just wrapped the content within footer.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord