Design comparison
Solution retrospective
Would appreciate any feedback, although I am just starting out I look forward to trying new challenges!
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello π. Congratulation on successfully completing your first challenge π ! !
I have some recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS π¨:
-
To achieve a vertical centering effect in this challenge, you'll want to add a height to your < body> element. Also, use the "justify-content: center" property works for centering your container vertically.
body { background-color: hsl(212, 45%, 89%); display: flex; min-height: 100vh; align-items: center; flex-direction: column; justify-content: center; }
- You should use the
box-sizing: border-box
property to make thewidth
andheight
properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here π.
CSS Reset π:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
2@ariglPosted about 1 year ago@MelvinAguilar Thank you Melvin. I adjusted it based on your feedback, I will look into using a CSS reset for the next time, as it reverted quite a few of my parameters. Appreciate your help.
0 - Use semantic elements such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord