Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h2> with <h1> to make the content/page accessible.
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center the article on the page using flexbox only instead of flexbox and margin, add
justify-content: center; align-items: center; min-height: 100vh
to the body and remove the margin value in the sectionbody{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
For a responsive content which wont require a media query for this challenge, replace the width in the article with
max-width
.Give the body a background-color of hsl(212, 45%, 89%), there is no need to give the section a background-color.
Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@Radu-APosted over 1 year ago@Hassiai Wow, I really apreciate that. Are you an angel or something?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord