Skip to content
Submitted 2 months ago

QR Code in static html and css

P
David Lemvigh•200
@dlemvigh
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Tried to use static HTML and CSS. No frameworks or libraries.

What challenges did you encounter, and how did you overcome them?

How to implement design-tokens without frameworks. Decided to use CSS variables.

How to use google fonts. I did remember the google fonts website makes it fairly by generating the needed html with preconnect links and everything.

What specific areas of your project would you like help with?

I know i use some possibly overly generic naming convensions like .text and .title, better names would probably be .card-title and .card-text to be a bit more modular.

Community feedback

  • P
    MessyEssay•30
    @MessyEssayPosted 2 months ago

    The solution looks good and close enough to the design. My only critique would be to move the css to its own file to make the code more readable. The content is static and small enough to be seen without scrolling so the addition of an extra file is not necessary. The H1 tag on the first text element is a nice touch for SEO but ultimately unnecessary for the same reason the css can be put in the head instead of in a separate file.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord