@rayaatta
Posted
Hi Bro 👋, congratulations on completing this challenge 🎉
I only have a few tips to suggest.
1
You need to make your html more semantic.
Try changing
<div class="qr-box"> to <main class="qr-box">
2
Since the qr code image is not decorative fill it's alt attribute with text describing where it leads to i.e ```alt="qr code leading to frontend mentor.io"
3
Change
height: 100vh; to min-height:100vh;
this ensures that content does not overflow on short devices or mobile devices in landscape mode.
4 Bro this is awesome I specifically liked those flowing pseudo classes on hover,man this is amazing 🤩. Happy coding ✌️
Marked as helpful
@RyanAbdaul
Posted
Hey @rayaatta Thanks for your feedback, and for your tips either, I really appreciate them. I did as you said in my next design, the one that I am about to upload it now, so thanks again for these tip. plus, ehem, thanks for your compliment really thanks. I'm going to follow you so I can learn more from your design. It was great to see you.❤
