Design comparison
Solution retrospective
I think that i did a good job, i probably have a problem with the size of my main container, but the rest is fine i think. It shrink well to a smaller size page format.
What challenges did you encounter, and how did you overcome them?I think the way to make it responsive, i don't know if i used the good method by using a media query, i wished i could do it without using any, but i don't think it was possible.
What specific areas of your project would you like help with?With my Responsive method, did i did well by using a media query, should i have use it at a higher width, or was there another way to do it ?
Community feedback
- @DartheryonPosted 6 months ago
I think it is a good work. It could be better if you take a look on the figma file and the meassures defined on it :) Taking a look into your repo, I can see you did not change the readme as the exercise suggest us to. It would be nices if you take the time to makeit, using the readme-template provided, as a guide.
It seems there might be some accesibilites issues you can improve. I refer to landmarks, specially.
You use a h2 tag without using previously a h1 tag. Remember that those tags are not a matter of size, but a semantic important part of the document. Please take a look on it :)
Marked as helpful0@P-MingiPosted 6 months ago@Dartheryon Thank you very much for your detailed answer, i will take a look and improve it.
It help me a lot :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord