@Dartheryon
Posted
I think it is a good work. It could be better if you take a look on the figma file and the meassures defined on it :) Taking a look into your repo, I can see you did not change the readme as the exercise suggest us to. It would be nices if you take the time to makeit, using the readme-template provided, as a guide.
It seems there might be some accesibilites issues you can improve. I refer to landmarks, specially.
You use a h2 tag without using previously a h1 tag. Remember that those tags are not a matter of size, but a semantic important part of the document. Please take a look on it :)
Marked as helpful
@P-Mingi
Posted
@Dartheryon Thank you very much for your detailed answer, i will take a look and improve it.
It help me a lot :)