QR Code - [HTML, CSS, SASS, Flexbox, CSS Grid]

Community feedback

• 

  dimar hanung•560

  @dimar-hanungPosted over 1 year ago

  Hi there 👋, congrats, Congratulations on completing the challenge, i have some feedback might useful for you.

  That i like:

  1. first i like your slicing result is very similar, just little difference in shadow and font.
  2. i like the way you separate sections into a structured folder
  3. the responsive is pretty good, even until galaxy fold 🙌

  My feedback:

  1. my opinion the comment in your code is not needed, example <!-- CARD QR IMAGE ->, because your classname that you created already represents what it is for, example class="card__qr-link" , by removing the comment it will make it clearer

  anyways good solution!, i hope my feedback can be useful, thanks 🙌

  1

  ---

  

  Dev Truce•140

  @DevTrucePosted over 1 year ago

  Hey @dimar-hanung !

  Thank you for taking the time to comment on my solution, I am glad that I was able to make things look good and that you are impressed! In regards to the comments I know I for sure make a lot of rather useless comments but I am trying to get into the habit of splitting things up, creating sections to make my code easy to understand and read. I will have to create some more useful comments!

  0