Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
width: 100dvw
property formain
element is not necessary. because it's a block level element which will take the full width of the page by default.
- Use
min-height: 100dvh
forbody
instead ofheight: 100dvh
. Setting theheight: 100dvh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100dvh
then thebody
will have100dvh
height no matter what. Even if the content spans more than100dvh
of viewport.
- But if we set
min-height: 100dvh
then thebody
will start at100dvh
, if the content pushes thebody
beyond100dvh
it will continue growing. However if you have content that takes less than100dvh
it will still take100dvh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1