Skip to content
Submitted about 2 months ago

Qr code |HTML & CSS|

Abhi•320
@abhi-zero
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • Overusing <div> tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like <header>, <section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.

        <div class="img">
      <img src="./images/image-qr-code.png" alt="QR">
    </div>

    • Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images,

    • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

    • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

    • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

    I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

    Marked as helpful
    0
    Abhi•320
    @abhi-zeroPosted about 2 months ago

    @Stroudy

    First of all, thank you for reviewing my code. It's great to have people like you on this platform. I read your comment, and the instructions were very helpful. I'll work on the improvements you suggested in the comment section. Thanks for the reference links as well; I learned a lot from them.

    -Once again, thank you for reviewing my code and offering suggestions. Wishing you and your family good health and happiness!

    1
    Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hey @abhi-zero, Your welcome, Take your time it is not a race, Build a strong foundation. 💪

    1
  • lynx232•110
    @lynx232Posted about 2 months ago

    "Does the solution include semantic HTML?" Replace the div elements with semantic elements such as "<figure>"

    "Is it accessible, and what improvements could be made?" Places the css file in its own folder, such as "css" folder(for good practice sake). Add a background shadow to the "main" element in css.

    "Is the code well-structured, readable, and reusable?" Yes.

    "Does the solution differ considerably from the design?" No. Good job!

    1
    Abhi•320
    @abhi-zeroPosted about 2 months ago

    @lynx232

    First of all, thank you for reviewing my code. It's great to have people like you on this platform. I read your comment, and you gave me some helpful instructions. I'm not familiar with the <figure> tag, but as you suggested, I'm going to start working with this semantic tag. From now on, I'll also place my CSS file in its own CSS folder. Once again, thank you for reviewing my code and offering suggestions. Wishing you and your family good health and happiness!

    0
    lynx232•110
    @lynx232Posted about 2 months ago

    @abhi-zero Likewise, my friend!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord