Qr Code HTML & CSS.

Community feedback

• 

  Lyna•260

  @lynaIFRPosted 4 months ago

  Hi, congrats on completing this project! It looks good.

  I took a look at your code, it's well written, but here are some things you can do better:

  • Always use rem for font-size never px.
  • To make a good CSS reset, I invite you to check Josh Comeau CSS Reset, It was very useful for me.
  • You should set a min-height : 100vh; for the body, so that it can use all the frame height.
  • In the HTML, I think it would be better to contain the elements in a div or more, because using values for the margin and padding to center elements is a bad practice. Check out Anamol Soman article to have a better understanding on how to do it.

  I hope this feedback will be helpful for you in the upcoming challenges, keep it up 😁

  Marked as helpful

  0

  ---

  

  Jonas Chacon•110

  @jonaschaconPosted 4 months ago

  Thank you for the compliments and the valuable feedback!😃@lynaIFR

  0

  

  Lyna•260

  @lynaIFRPosted 4 months ago

  You're welcome! @jonaschacon

  0