Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Code HTML & CSS.

@jonaschacon

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lyna 260

@lynaIFR

Posted

Hi, congrats on completing this project! It looks good.

I took a look at your code, it's well written, but here are some things you can do better:

  • Always use rem for font-size never px.
  • To make a good CSS reset, I invite you to check Josh Comeau CSS Reset, It was very useful for me.
  • You should set a min-height : 100vh; for the body, so that it can use all the frame height.
  • In the HTML, I think it would be better to contain the elements in a div or more, because using values for the margin and padding to center elements is a bad practice. Check out Anamol Soman article to have a better understanding on how to do it.

I hope this feedback will be helpful for you in the upcoming challenges, keep it up 😁

Marked as helpful

0

@jonaschacon

Posted

Thank you for the compliments and the valuable feedback!😃@lynaIFR

0
Lyna 260

@lynaIFR

Posted

You're welcome! @jonaschacon

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord