QR Code - HTML & CSS

Community feedback

• 

  P

  Ryan Bradley•630

  @ryanbradley-webdevPosted over 1 year ago

  Great work!

  At first glance it seems responsive. I looked through your CSS file and it seems pretty good, although there are a couple instances of using flex/grid properties when the display isn't set to either. Not a huge issue, but I could lead to some frustration.

  The one thing I noticed when looking at it on a smaller screen is that the footer overlaps the main content. Positioning the footer as absolute can definitely cause this if there's any overflow. An easy fix I've found when the page content is minimal (like this project) is to set the body's display to flex, direction column, min-height 100vh, and then set the main element (or whatever element you want to take up the most space) flex-grow to 1. This should shove everything else to the top or bottom as appropriate.

  I hope this helps! Great job on this project!

  Marked as helpful

  0

  ---

  

  AzizFezz•10

  @AzizFezzPosted over 1 year ago

  @ryanbradley-webdev Thank you for the comment

  0