QR Code Holder

👾Hi Clutz, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

• Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/
• Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
• Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

✌️ I hope this helps you and happy coding!

maybe it would be better to use values that allow the sizes of your elements to adapt to the screen size?

I see that you use pixels but maybe it would be better to use rem or em as a value to be able to adapt the size of the window to the size of the screen.

otherwise it's all pretty good except the respect of the proportions of the original model :)

it's about your h1 tag it's supposed to appear wider than the QR code .

Congratulations for your challenge and good continuation;)

Mirko

Translated with www.DeepL.com/Translator (free version)