QR Code hard coded sizes - not responsive

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="rectangle"> with a main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .rectangle on the page using flexbox, replace the height in the body with min-height: 100vh.

  Replace the height in .rectangle with a padding value for all the sides anf give the img a max-width of 100%.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  Liam Malby•20

  @liammalbyPosted almost 2 years ago

  At first I failed to include semantic HTML. However in the second version, I implemented the changes suggested by community mentors.

  0