@LucaJahnen
Posted
Hello there,
Your submission looks really good however I would implement some minor changes:
styles
Consider adding a reset, e. g.
`* {
margin: 0;
padding: 0;
box-sizing: border-box;
}`
This removes default padding from elements like headings and allows you to anticipate how these elements are going to behave.
semantic html
Please use an <h1>
element for your heading. Overall there are six headings from <h1>
to <h6>
. <h1>
being most important and <h6>
least important.
font
If you use an <h1>
element for your heading you'll notice the font-size
and font-weight
will increase. Manually adjust the font-size
and your submission will be even closer to the Design.
If you want to learn more about fonts consider checking out this website: Fonts | MDN.
units
Consider using relative units like vw or percentages for widths and heights so your submission will be responsive. However using px or rem for border-radius
or font-size
is okay