Skip to content
Submitted 10 months ago

Qr Code - Frontend Mentor

Chockplay•60
@Chockplay
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Thanks for view my post. Please fell free to provide feedback, recommentadions, suggestions or code optimizations to improve this project.

Have fun building!!!

Community feedback

  • Theo Harris•140
    @Theosaurus-RexPosted 10 months ago

    Hey @Chockplay, congrats on completing the challenge!

    This looks pretty good - a couple of small suggestions to help improve accessibility and semantics

    • It's reasonable to assume that in a real webpage there would be a <h1>, but in this case the component is isolated, so having a <h2> with no <h1> doesn't make much sense semantically
    • Your QR code image needs alt text, as it's a functional image and not purely decorative - some descriptive text indicating where scanning it will lead the user to is ideal

    Otherwise, great work! ✨

    Marked as helpful
    1
    Chockplay•60
    @ChockplayPosted 10 months ago

    Hi @Theosaurus-Rex, I hope you're well. Thanks for your comment. I already modified the code applying your good suggestions.

    Thank you very much!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord