Theo Harris• 140
@Theosaurus-Rex
Posted
Hey @Chockplay, congrats on completing the challenge!
This looks pretty good - a couple of small suggestions to help improve accessibility and semantics
- It's reasonable to assume that in a real webpage there would be a
<h1>, but in this case the component is isolated, so having a<h2>with no<h1>doesn't make much sense semantically - Your QR code image needs alt text, as it's a functional image and not purely decorative - some descriptive text indicating where scanning it will lead the user to is ideal
Otherwise, great work! ✨
Marked as helpful
1
Chockplay• 60
@Chockplay
Posted
Hi @Theosaurus-Rex, I hope you're well. Thanks for your comment. I already modified the code applying your good suggestions.
Thank you very much!
1
