QR CODE || Frontend Mentor

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Deeptansh, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the br is for break the text
  • centering a div with fixed positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • the image is broken because you forgot to upload it to the repository

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Deeptansh Verma•30

  @DeeptanshV1707Posted over 2 years ago

  @denielden Thank You for looking at my code and guidance. I will surely keep these points in mind !!

  1
• 

  Gabriel_BC•300

  @GabrielBC2021Posted over 2 years ago

  Hello, just some little details

  1.- You are not uploading your files the right way on GitHub, you don't have to upload the folder, just the components (what is inside the folder).

  2.- I know is a small project, but you shouldn't mix your CSS in your HTML, you have to separate your CSS stylesheet and in your HTML use the tag link to link that stylesheet.

  3.- You are not including media queries, so your website could be responsive, if you look at it un Firefox developer view, when you are in device pov, your website Is falling apart, with media queries we prevent that so you can check that out.

  Little details that will make your website look better :D

  Marked as helpful

  0