@denielden
Posted
Hi Deeptansh, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the card for improve the Accessibility img
element must have analt
attribute, it's very important!- remove all unnecessary code, the less you write the better as well as being clearer: for example the
br
is for break the text - centering a
div
withfixed
positioning is now deprecated, it uses modern css likeflexbox or grid
- try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - the image is broken because you forgot to upload it to the repository
Hope this help and happy coding!
Marked as helpful
@DeeptanshV1707
Posted
@denielden Thank You for looking at my code and guidance. I will surely keep these points in mind !!