Skip to content
Submitted about 2 months ago

QR-code frontend mentor

Alexander Gusev•170
@WaRaGiSmYnIcKnAmE
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted about 2 months ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Replace <section> with a <main>.

    • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • Move font-family from html to body, and remove it elsewhere. Setting the font on the body is all you need, as the children will inherit the font value.

    • Remove margin-top, it is not needed. Instead, you need to add min-height: 100svh. The body, and thus the main is only as tall as its content by default, meaning it has no available vertical space to center itself in. Adding the min-height solves this issue, and is much more efficient than setting a top margin.

    • Remove all widths and min-heights in px. It's not recommended to give components a fixed size in px, as we want it to shrink and grow in response to the screen size.

    • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

    • I would increase the padding on the card to 16px.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px.

    Marked as helpful
    1
    Alexander Gusev•170
    @WaRaGiSmYnIcKnAmEPosted about 2 months ago

    @Islandstone89 Thanks for the comments, I will definitely add them to my solution!

    1
  • InoDash•20
    @inocent345fPosted about 2 months ago

    bien

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord