QR CODE FLEXBOX!! My first challenge!!

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @JhonyDomingos, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  2.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  3.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Jhonatan•90

  @JhonyDomingosPosted about 2 years ago

  @correlucas Ty for your suggestions, I'll update my code with your recommendations!! Definitely I will use all of them 🙂

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @JhonyDomingos Then say me if you liked it and if was useful for you. Keep posting amazing content =)

  Marked as helpful

  0

  

  Jhonatan•90

  @JhonyDomingosPosted about 2 years ago

  @correlucas I did few changes following your tips, if you can check I'll be to much thankful!

  0
• 

  Effy Zhang•60

  @Effyz1228Posted about 2 years ago

  Hi Jhonatan,

  I liked that you used flex box for the layout. I found one typo in your code. The last line, you typed 0,3rem instead of 0.3rem. Please check the code snippet below. Overall, I think you did good!

  .qr-code { display:flex; border-radius: 0.8rem; background-color: hsl(0, 0%, 100%); padding: 0.5rem; margin: 0,3rem auto;}

  Marked as helpful

  0

  ---

  

  Jhonatan•90

  @JhonyDomingosPosted about 2 years ago

  @Effyz1228 Thank you bro, This is my first solution, had to many mistakes, but, soon I will remake the code using the knowledge that I got !! thx for revising !!

  0