Skip to content
Submitted over 1 year ago

QR Code - Flexbox basics

generieyyc•160
@generieyyc
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi generieyyc, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use alt (alternate text) attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • For proper centering the container(whole card) vertically and horizontally you can use code as:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

    Or you can learn centering from here.

    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    If the Feedback is Helpful for you, Don't Forget to upvote and click on MARKED AS HELPFUL 😇......That Will Make me feel Happy to Help someone😇

    Marked as helpful
    1
    generieyyc•160
    @generieyycPosted over 1 year ago

    @atif-dev This is really good feedback and learning a lot. Thank you for reviewing it and I'll incorporate these tips on my next one.

    0
  • safdar•130
    @sfdrkPosted over 1 year ago

    am just adding that ... always try to make image styles as :-

    img{ max-width:100%; width:100%; height:auto; }

    So it will resize relative to your screen sizes. I mean for better Responsiveness

    Marked as helpful
    0
    generieyyc•160
    @generieyycPosted over 1 year ago

    @sfdrk hey, thanks for this. I was thinking of a solution for that, and you just helped me out!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord