Atif Iqbal• 3,200
@atif-dev
Posted
Hi generieyyc, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use
alt(alternate text) attribute as it is mentioned in your Accessibility Report.altattribute is used for Screen readers technology. Whyaltattribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
- For proper centering the container(whole card) vertically and horizontally you can use code as:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
Or you can learn centering from here.
- When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
If the Feedback is Helpful for you, Don't Forget to upvote and click on MARKED AS HELPFUL 😇......That Will Make me feel Happy to Help someone😇
Marked as helpful
1
generieyyc• 160
@generieyyc
Posted
@atif-dev This is really good feedback and learning a lot. Thank you for reviewing it and I'll incorporate these tips on my next one.
0
